fix: grant guild permissions immediately after creation - #771
Merged
Conversation
darbyjack
marked this pull request as ready for review
July 12, 2026 02:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure a newly created guild member is added to the member cache before Guilds resolves and applies the guild-tier and role permission nodes.
Root cause
Guild creation called
addGuildPermsandaddRolePermbefore adding the creator tomemberCache. Both permission methods look the player's guild up through that cache, so the lookup returnednulland the initial permission assignment was skipped until the player rejoined.Changes
memberCacheimmediately after the guild is registeredValidation
CommandCreate.ktFixes #708